-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed pod logs core api request errors. #227
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: homer6 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold This PR is for review only and will not be merged. |
@@ -35170,7 +35170,7 @@ CoreV1API_readNamespacedPodLog(apiClient_t *apiClient, char *name, char *_namesp | |||
keyPairQuery_timestamps = keyValuePair_create(keyQuery_timestamps, valueQuery_timestamps); | |||
list_addElement(localVarQueryParameters,keyPairQuery_timestamps); | |||
} | |||
list_addElement(localVarHeaderType,"text/plain"); //produces | |||
//list_addElement(localVarHeaderType,"text/plain"); //produces removed text/plain as it is rejected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't comment this line, will the result be correct? I don't think this should affect the results.
The text/plain
header is defined in the Kubernetes OpenAPI spec. This line is automatically gnereated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that header is sent, it'll respond with a 400-level instead of a 200. The comment is needed to ensure that the header is not sent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I'll try this API.
@@ -35193,9 +35193,11 @@ CoreV1API_readNamespacedPodLog(apiClient_t *apiClient, char *name, char *_namesp | |||
// printf("%s\n","Unauthorized"); | |||
//} | |||
//primitive return type simple | |||
char* elementToReturn = strdup((char*)apiClient->dataReceived); | |||
char* elementToReturn = NULL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good catch !
Can you make code changes in the upstream code generator instead of here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is for your reference: OpenAPITools/openapi-generator#17540
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This fix is for issue #222